feat(orchestrator): rewrite main.go to use pipeline.Construct - #440
Merged
Conversation
JamyDev
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
July 24, 2026 19:05
This was referenced Jul 24, 2026
behinddwalls
approved these changes
Jul 24, 2026
behinddwalls
approved these changes
Jul 24, 2026
JamyDev
force-pushed
the
jamy/orchestrator-rewrite
branch
from
July 29, 2026 17:48
9a5c1f6 to
e2a3dbc
Compare
JamyDev
force-pushed
the
jamy/orchestrator-rewrite
branch
from
July 30, 2026 05:44
e2a3dbc to
cc413f8
Compare
github-merge-queue
Bot
removed this pull request from the merge queue because the pull requests in the stack were not ordered correctly in the queue
Jul 30, 2026
JamyDev
force-pushed
the
jamy/orchestrator-rewrite
branch
from
July 30, 2026 06:06
cc413f8 to
f4d66b3
Compare
JamyDev
force-pushed
the
jamy/orchestrator-rewrite
branch
from
July 30, 2026 17:31
f4d66b3 to
1a3e5d8
Compare
Introduce `submitqueue/orchestrator/pipeline.go` with three exports: - `Deps` struct: the full set of dependencies (logger, scope, storage, counter, and four extension factories) the orchestrator pipeline needs. This struct IS the service's public API toward deployers. - `Stages` slice: the complete 12-stage pipeline topology as a typed table of `pipeline.Stage[Deps]`. Each row declares a primary controller constructor and its DLQ reconciler. Adding a stage = adding one row. - `PublishOnlyTopics`: topics the orchestrator publishes to but does not consume (log, merge-conflict-check, runway-merge). - `Controllers` struct + `NewControllers`: RPC-facing controllers (currently Ping), NOT bound to any wire contract. Pure addition alongside the existing main.go wiring — no behavioral changes. Ref: doc/rfc/submitqueue/modular-queue-wiring.md (Step 3) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The score controller package does not exist — scoring was folded into the speculator. Remove the score stage from Stages, the Scorer field from Deps, and the controller/score import. Update the pipeline diagram comment accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
One consumer group ("orchestrator") for all topics in the service,
matching the convention that per-stage groups are unnecessary unless
instances are split by stage.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace ~500 lines of manual wiring with a single pipeline.Construct call. The orchestrator's run() now: 1. Builds per-queue profiles (Profile/Profiles in profiles.go) 2. Populates orchestrator.Deps with profile-derived Factory adapters 3. Calls pipeline.Construct(deps, orchestrator.Stages, ...) to get a single lifecycle.Component 4. Drives Start/Stop on that component Removed: - newTopicRegistry (topology now declared in orchestrator.Stages) - queueExtensions/queueRegistry (replaced by Profile/Profiles) - Three *Factory adapter structs (replaced by func-type adapters) - registerPrimaryControllers (stages declare their own New funcs) - registerDLQControllers (stages declare their own DLQ funcs) The host retains: infrastructure bootstrap, per-queue profile construction, change provider wiring, gRPC server lifecycle, and signal handling — all host-specific concerns per the RFC. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JamyDev
force-pushed
the
jamy/orchestrator-rewrite
branch
from
July 30, 2026 18:01
1a3e5d8 to
48f1e7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace ~500 lines of manual wiring with a single pipeline.Construct call. The orchestrator's run() now:
Removed:
The host retains: infrastructure bootstrap, per-queue profile construction, change provider wiring, gRPC server lifecycle, and signal handling — all host-specific concerns per the RFC.
Test Plan
Boot service with main.go and test against simulator
Issue
https://linear.app/uber/issue/CODEM-209/example-figure-out-a-better-structure-for-wiring-up
Stack